[Fix #836] Implement beforeAgentInvocation and afterAgentInvocation f…#994
[Fix #836] Implement beforeAgentInvocation and afterAgentInvocation f…#994treblereel wants to merge 2 commits intoserverlessworkflow:mainfrom
Conversation
…rAgentInvocation for LC4J Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
Thanks, @treblereel but we also must adapt our implementation:
It should be part of this PR. Basically, the missing before|afterAgentInvocation methods in our LC4J impl.
| private final AtomicReference<Consumer<AgenticScope>> beforeAgentInvocation = | ||
| new AtomicReference<>(); | ||
| private final AtomicReference<Consumer<AgenticScope>> afterAgentInvocation = | ||
| new AtomicReference<>(); |
There was a problem hiding this comment.
Why atomic? Is there a concurrency for changing these builders somewhere?
this one is tough ... |
I know! That was the real reason why I opened the issue. 😬 |
Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
Can you please add a few unit tests to validate this implementation?
|
Done in #1039. |
2 participants
…or LC4J
#836 Implement beforeAgentInvocation and afterAgentInvocation for LC4J 1.6.0